Skip to content

[NBS] Add TLogTitle to *MultiAgentWriteActor#6000

Open
zavik001 wants to merge 3 commits into
ydb-platform:mainfrom
zavik001:users/zavik001/log-title-nonrepl-multi-agent-write-actor-clean
Open

[NBS] Add TLogTitle to *MultiAgentWriteActor#6000
zavik001 wants to merge 3 commits into
ydb-platform:mainfrom
zavik001:users/zavik001/log-title-nonrepl-multi-agent-write-actor-clean

Conversation

@zavik001
Copy link
Copy Markdown
Contributor

@zavik001 zavik001 commented May 20, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

@komarevtsev-d komarevtsev-d added blockstore Add this label to run only cloud/blockstore build and tests on PR large-tests Launch large tests for PR ok-to-test Label to approve test launch for external members labels May 20, 2026
@github-actions github-actions Bot removed the ok-to-test Label to approve test launch for external members label May 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026 •
edited
Loading

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 11807s): all tests PASSED for commit c5c8be0.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
6585 6584 0 0 0 1 0

drbasic
drbasic reviewed May 21, 2026
View reviewed changes
Comment thread cloud/blockstore/libs/storage/partition_nonrepl/multi_agent_write_actor.h Outdated
NProto::TError ReplicasCollectiveResponse;
size_t RemainResponseCount = 0;

TChildLogTitle LogTitle;
Copy link
Copy Markdown
Collaborator

@drbasic drbasic May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Его можно const делать

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026 •
edited
Loading

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 11630s): all tests PASSED for commit c11de26.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
6585 6584 0 0 0 1 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 25, 2026 •
edited
Loading

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

  • ✅ blockstore

nisqatsi
nisqatsi approved these changes May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@nisqatsi nisqatsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

К возможному будущему развитию - я бы убрал TChildLogTitle, оставив только TLogTitle, который по GetChild/MakeChild возвращает модифицированную копию себя. Уберется дублирующий метод TChildLogTitle::GetWithTime, станет меньше сущностей (минус класс).
В общем, на подумать, обсуди с Кириллом, может, у него какие-либо "против" есть.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drbasic drbasic drbasic left review comments

@nisqatsi nisqatsi nisqatsi approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

blockstore Add this label to run only cloud/blockstore build and tests on PR large-tests Launch large tests for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zavik001 @drbasic @nisqatsi @komarevtsev-d