feat(projects): let web-only people be found and added as members - #903
Closed
iGotsIt wants to merge 1 commit into
Closed
feat(projects): let web-only people be found and added as members#903iGotsIt wants to merge 1 commit into
iGotsIt wants to merge 1 commit into
Conversation
People who sign in by email (AUTH_ALLOWED_EMAILS) but have no Slack account were only visible to the directory as an exact-match fallback in the messaging layer, and project add-member validated against the raw Slack roster, so the web picker could neither find them by a partial name nor add them. Fold those people into the directory store itself with a wrapper applied at wiring time: list, get, and resolve now see the synced roster plus the configured email principals, with the synced row winning on a shared email and partial matches merging into one candidate list. That removes the emailAuthMembers dependency and the three ad-hoc merges from the messaging layer, and every directory reader (project membership, admin users, cron names, keychain scope names) sees the same people. Claude-Session: https://claude.ai/code/session_017NA5c6F6xJsuSLbcgh4Efe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
People who sign in by email (AUTH_ALLOWED_EMAILS) but have no Slack account were only visible to the directory as an exact-match fallback in the messaging layer, and project add-member validated against the raw Slack roster, so the web picker could neither find them by a partial name nor add them.
Fold those people into the directory store itself with a wrapper applied at wiring time: list, get, and resolve now see the synced roster plus the configured email principals, with the synced row winning on a shared email and partial matches merging into one candidate list. That removes the emailAuthMembers dependency and the three ad-hoc merges from the messaging layer, and every directory reader (project membership, admin users, cron names, keychain scope names) sees the same people.
Claude-Session: https://claude.ai/code/session_017NA5c6F6xJsuSLbcgh4Efe
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.