fix: sanitize the failure text stored on a failed run - #898
Open
16francej wants to merge 1 commit into
Open
Conversation
A failed run stored the raw thrown error as its user-facing reason, so clients rendered internal error text even though the durable transcript already replaces it with a generic message — the same failure changed wording on reload. Route the stored reason through the existing turnFailureMessage helper so there is one conversion from an internal error to user-facing text, shared by every surface that reads it. The raw error still propagates to the caller and to the operator error log. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed run stored the raw thrown error as its user-facing reason, so clients rendered internal error text even though the durable transcript already replaces it with a generic message — the same failure changed wording on reload. The stored reason now goes through the existing
turnFailureMessagehelper: one conversion from internal error to user-facing text, shared by every surface. The raw error still reaches the caller and the operator error log.GET /v1/runs/:idno longer carries internal error texttsc,eslint,oxlint,prettier, tests greenNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.