Add safe native recording rename workflow - #30
Draft
hotzenplotz5 wants to merge 120 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency
This pull request depends on #29 and must not be merged before #29.
This branch is stacked on
hotzenplotz5:feature/recording-move-preflight. Until #29 is merged, GitHub may also show the Trash and Move changes in this pull request. After #29 is merged, the branch will be rebased onto the updatedmaster, leaving only the Rename changes.Summary
This pull request adds a safe native recording rename workflow on top of the recording move infrastructure introduced by #29.
API
POST /recordings/rename/preview.jsonPOST /recordings/rename/validate.jsonPOST /recordings/rename.jsonSafety model
.and...recdirectoryalready-renamedVerified tests
make test-recording-rename-planmake test-recording-rename-preflightgit diff --checkVerified real VDR integration
Tested with a completed 285 MB recording:
renamedvdr-recordingaction renamehook was executedalready-renamedDocumentation
RECORDING_RENAME_API.md