ja: navigate.yaml stopped speaking English, and now uses Japanese word order - #20
yasumorishima wants to merge 1 commit into
Conversation
…d order Three of the navigation announcements were still in the shape en gives them. - The 2D move announcements spoke $Move2D as it stands, and that variable holds an English literal: 'in', 'out of', 'end of', 'start of'. Zooming into x squared said "ズーム イン; in 底; x", with the "in" read out in English. Those four are the only values this file ever sets, so the two rules that emit it now map them (に入る / から出る / の終わり / の始め) and say them after the part they apply to, which is where Japanese wants them: "ズーム イン; 底 に入る; x". - Undo named the verb first: 元に戻す ズームイン is "undo zoom in" word for word. Japanese names what is being undone first, ズームイン を 元に戻す. - The placemarker announcements had the same order -- 読み上げ プレースホルダー 3 for "read placeholder 3". They now name the placeholder and its number first and then take the particle the matching move command already uses (を 読み上げ, を 説明, に 移動), the pattern daisy#752 set up. セット becomes 設定, the ordinary Japanese for setting a value. The four rules whose children are reordered carry `# audit-ignore`. The divergence from en is the point of the change, and without the marker the rule difference count goes 30 -> 34 and stops being usable as evidence that a PR did not break the rules. The marker sits at the end of the `- name:` line: that is the position that works today, and the one 170 of the 298 markers under Rules/Languages already use. (daisy#742 is deciding which position becomes canonical; if it moves, these move with the rest.) This also promotes 底 / 上付き文字 / 下付き文字 to T:, checked against en's base / superscript / subscript. In en the `phrase(...)` hints on those lines and the values they annotate do not agree with each other; ja follows the values, which are what is actually spoken. audit-translations ja: untranslated text 3447 -> 3436, which is the 8 lines this changes plus those 3 promotions; rule differences 30 -> 30; missing, extra and definition counts unchanged at 0. Tests: four in navigate.rs, with a helper that compares the whole announcement rather than the command prefix, since none of these three is a prefix. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XzNYYoiVRzKGnDEWTJnuHh
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Japanese navigation rules now place targets before movement and action phrases. Undo messages use Japanese action-first wording. Tests now compare complete speech for notation movement, undo, and placemarker commands. ChangesJapanese navigation speech
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~15 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The Japanese navigation wording changes are covered by matching full-announcement tests, with no actionable merge risk identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 71.43% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Preflight only; the upstream PR is daisy#773. |
1 participant
Three of the Japanese navigation announcements were still in the shape en gives them, and one of them was reading English out loud.
$Move2Dheld an English literal. The variable is set to'in','out of','end of'or'start of'— those four and nothing else in this file — and bothinto-or-out-of-*rules emitted it withx: "$Move2D", straight from en where that is already English. Zooming into x squared announced:Japanese also wants it after the part it applies to, so the mapping (に入る / から出る / の終わり / の始め) is emitted after the part name instead of in front of it.
Undo named the verb first. 元に戻す ズームイン is "undo zoom in" word for word; Japanese names what is being undone and then 元に戻す.
The placemarkers had the same order. 読み上げ プレースホルダー 3 is "read placeholder 3". They now name the placeholder and its number first and take the particle the matching move command already uses — を 読み上げ, を 説明, に 移動 — which is the pattern daisy#752 set up for the move commands. セット becomes 設定, the ordinary Japanese for setting a value.
# audit-ignoreon four rules. Reordering the children is the point of the change, so those four rules diverge from en by construction. Without the marker the rule-difference count goes 30 → 34, and I lean on that count in every PR as evidence that nothing was broken. I put the marker at the end of the- name:line: it is the position that works today, and the one 170 of the 298 markers underRules/Languagesalready use. daisy#742 is deciding which position becomes canonical — if it moves, these move with the rest.One promotion that is not a rewrite. 底 / 上付き文字 / 下付き文字 go to
T:, checked against en'sbase/superscript/subscript. Worth a note while I was in there: in en those four lines havephrase(...)hints that disagree with the values they annotate (then: [t: "pre-subscript"] # phrase(x with 'subscript' 2)), and the condition comment above them reads the other way round from what the XPath selects. The values look right and the comments look stale, so ja follows the values, which are what is spoken.Checks.
audit-translations ja: untranslated text 3447 → 3436 — the 8 lines this rewrites plus those 3 promotions; rule differences 30 → 30; missing, extra and definition counts unchanged at 0. Baseline measured onupstream/jaat the same time.Tests. Four in
navigate.rs, with a helper that compares the whole announcement instead of stopping at the first pause, since none of these three is a command prefix. The existing prefix tests are untouched.This does not conflict with daisy#772: they touch different files, and I merged both orders locally to check.
Summary by CodeRabbit