Repository navigation
preflight: ja shared rules cleanup - #17
yasumorishima wants to merge 4 commits into
Conversation
…lose marks
Two groups of fixes in the shared rule files.
1. Three fraction rules read the fraction backwards. Japanese puts the
denominator first: 3/4 is "4 分の 3", so "3 分の 4" is 4/3 -- a different
number, not just an odd phrasing. ClearSpeak and SimpleSpeak already swap
the operands (common-fraction), but the mfrac rules in SharedRules/default.yaml
(used by LiteralSpeak) and the fraction rule in overview.yaml (used by the
"describe" navigation command) did not.
- literal-simple and overview-default now say the denominator first.
- literal-default has explicit start/end markers, so it keeps the written
order and uses the borrowed オーバー: 分数 A オーバー B 分数終了. It also
opened with スタート, the English "start".
2. menclose notation names and two neighbouring rules were still the machine
translation:
- 上下矢印 for "up arrow" is an arrow with a head at each end, so uparrow,
updownarrow, leftrightarrow and both diagonal double ended arrows all
named the same thing.
- ダブルは対角矢印を終了 / 二重は対角矢印を終了 ("double is ends diagonal
arrow") are not sentences.
- 行動シンボル is an "action symbol"; the actuarial symbol is 保険数理記号.
- アラビア語の要素のシンボル reads "Arabic-language element symbol"; madrub
is the factorial symbol written in Arabic script.
- クロスアウト, ダウン矢印, ダウンの対角, サークル, ラウンドボックス, ボックス and
ロングディビジョンシンボル are transliterations of the English.
- 対角形 does not say which diagonal.
- 詳しくはこちら ("click here for details") was used for "above" in the mover
and munderover rules, opposite the 下 that is already there.
- ノルダム is Notre-Dame; a norm is ノルム.
- エントリー for a matrix entry is 成分, and a coordinate is 点, the word
geometry.yaml already uses.
Every line that was checked against the en rule beside it is promoted to T:.
Tests cover both fraction paths, the overview path, the menclose marks, above
and below, the norm and the matrix entry.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughJapanese speech rules now use denominator-first fraction ordering and revised terminology for annotations, enclosures, arrows, decimal points, matrix entries, and norms. Tests cover LiteralSpeak, ClearSpeak, and overview navigation behavior. ChangesJapanese speech rules
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This updates Japanese mathematical speech terminology and fraction ordering with corresponding coverage; no current merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai review |
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Preflight done; submitted upstream as daisy#756. |
1 participant
Preflight only (CI + CodeRabbit). Upstream PR will target daisy/MathCAT ja.
Summary by CodeRabbit
Bug Fixes
Tests