preflight: ja nPk permutation phrase

[yasumorishima]

Preflight only (CI + on-demand CodeRabbit). Not for merge here.

Summary by CodeRabbit

• Localization

  • Updated Japanese permutation notation speech to follow the displayed argument order and use clearer nPk phrasing.

• Bug Fixes

  • Corrected Japanese pronunciation of permutation expressions in both ClearSpeak and SimpleSpeak modes.

• Tests

  • Added coverage confirming notation such as P₂⁵ is read as “5 個から 2 個取る順列.”

[yasumorishima]

@coderabbitai review

[coderabbitai]

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 2f601ff9-0289-4875-971c-b13319ef7969

📥 Commits

Reviewing files that changed from the base of the PR and between 316b7d3 and c2a250e.

📒 Files selected for processing (2)

• Rules/Languages/ja/SharedRules/general.yaml
• tests/Languages/ja/ja.rs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The Japanese permutation rule now reads nPk arguments in display order with updated Japanese phrases. A test verifies the output for both ClearSpeak and SimpleSpeak.

Changes

Japanese permutation notation

Layer / File(s)	Summary
Permutation speech rule and validation Rules/Languages/ja/SharedRules/general.yaml, tests/Languages/ja/ja.rs	The rule now reads arguments as “個から” and “個取る順列”. The new test verifies “5 個から 2 個取る順列” for ClearSpeak and SimpleSpeak.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to c2a25

Japanese nPk notation now speaks the school-style display-order phrase, with coverage for both supported speech styles. No current merge-readiness risk remains.

Suggested reviewers: moritz-gross

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the Japanese nPk permutation phrase change. It is concise and related to the main changeset.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1 …
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ja-permutation

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[yasumorishima]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[yasumorishima]

Preflight done: CI all green (new test matches engine output exactly), CodeRabbit no actionable comments. Submitted upstream as daisy#747.