feat: add meaningful User-Agent header to outgoing HTTP requests#7153
Closed
thegoddo wants to merge 1 commit into
Closed
feat: add meaningful User-Agent header to outgoing HTTP requests#7153thegoddo wants to merge 1 commit into
thegoddo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Currently, Yarn 4 identifies itself with the default
gotuser-agent string (got (https://github.com/sindresorhus/got)) instead of identifying itself as Yarn. This makes it impossible for sysadmins and DevOps engineers to distinguish Yarn traffic or enforce package manager allow-lists across an organization.Closes #7149
How did you fix it?
Modified
packages/yarnpkg-core/sources/httpUtils.tsinside therequestImplfunction.YarnVersionfrom the core constants.User-Agentstring following the standard convention:yarn/${yarnVersion} node/${process.version}.gotOptions.headerswhile utilizing the spread operator (...headers) to ensure any explicitly passed custom headers are preserved and not overwritten.Checklist