fix: Stop using EBADF workaround for Node 24.16.0+#7152
Merged
Conversation
Node 24.16.0 backported nodejs/node#62835, so it can now disable the EBADF workaround to avoid similar breakage. This works similar to PR yarnpkg#7133.
Contributor
Author
|
The integration test failure looks unrelated to this change? I also tried running the test suite locally in the node:26.2.0 docker image and that test passed for me. Let me know if a change is needed for the test though. |
clemyan
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Node backported nodejs/node#62835 restoring
fspatchability, so we can now disable the same EBADF workaround for it.This follows the same pattern as #7133.
...
How did you fix it?
Changed the condition to only enable the workaround for node 24.15.x, as it is the only release with the issue.
I tested the adjusted version works on 24.16.0.
...
Checklist