fix(core): warn for workspace dev peer fallbacks#7142
Conversation
|
I took a pass at this against the current tree since it has been sitting for a bit. On PR head I also merged it into current One caveat: all visible GitHub Actions jobs are green, with only the expected big-endian skip, but the Netlify deploy-preview context is still red ( |
clemyan
left a comment
There was a problem hiding this comment.
- There needs to be an additional criterion to trigger the new warnings: that the workspace-workspace dependency must not be dev-only
- If a dev-dependency fallback forwards the peer request anyway, I think the "dev-only fallback" case can be handled as a "peer not provided" warning?
|
Updated in What changed:
Verification:
|
Summary
yarn explain peer-requirementsoutput for the new caseFixes #7139.
Testing
git diff --checkcorepack yarn typecheck:allcorepack yarn workspace @yarnpkg/cli build:cli --no-git-hashcorepack yarn test:integration pkg-tests-specs/sources/features/peerDependenciesMeta.test.ts -t "workspace peer dependency is satisfied" --runInBand