fix(core): Prevent concurrent yarn classic calls#7137
Open
rmoore-bn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
When preparing multiple packages from GitHub dependencies there is no concurrency control on calls to yarn classic. This breaks, as yarn classic's cache access is not concurrency safe.
Closes: #5349
How did you fix it?
Adds a new
pLimit(1)which wraps calls to yarn classic.An old PR exists for this problem which attempted to solve this in a more complicated way using yarn classic's mutex: #5373
A review comment suggest this approach instead, which this PR implements.
Checklist