fix: ignore keyboard shortcuts while typing in text fields - #785
Closed
wwhsaber wants to merge 1 commit into
Closed
Conversation
Single-key shortcuts (m/b/s/h and nav F-keys) fire even when focus is in inputs, textareas, or webpage form fields, closing or mutating the article while the user types. Closes yang991178#522
Author
|
Closing to keep this batch to 5 focused PRs (keeping #784 for the unread-count fix). Happy to reopen the keyboard-shortcut fix separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Disable single-key app shortcuts when the user is typing in form fields or when the article webview is showing the original webpage.
Why
Typing an email address (or any form input) could trigger shortcuts like m/b/s/h and close or mutate the article (issue #522).
Closes #522
Changes
Verification