Add matplotlib to the benchmark extra's docstring/README package list - #279
Conversation
|
@evanjain-dot is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@yakew7 - new PR touching a path you own, please review. |
|
@ahmdkaml @Shreyash0712 if u want you can review it asw |
|
Good to go. It's just adding matplotlib. |
|
@yakew7 btw what perms do I have? can I merge stuff asw? Idts as I don't see the button to do so. |
|
@Shreyash0712 you've got write access now (can push, open PRs, comment, review, etc.) and you're a co-code-owner of main is protected though: every PR needs 1 approving review, and it has to come from whoever CODEOWNERS says owns the touched paths ( on higher perms later - not ruling it out, not doing it yet either. you're the most prolific explainer contributor by far and the catch on #277 was a genuinely good piece of review, so it's earned you real trust. I'd want to see that extend past explainers first - reviewing/contributing to tests, scripts, or docs over the next couple months - before I'd extend CODEOWNERS further or anything closer to admin. will revisit then. |
|
I see. Love the system. A lot has changed in the repo since I joined. I'll do my best. |
|
yeah the repo grew a lot more with some active contributors asw |
|
Okay so can you make it so the bot starts to tag me in PRs as well? That way I'd get a notification. |
|
Not just from my domain - all of them. I don't mind. I'll review whenever I get time. @yakew7 |
Credits evanjain-dot's #277 (--html traceback fix + CLI test coverage) and #279 (matplotlib docstring fix), propcgamer20-png's #278 (favicon-parsing test coverage), and the two review-driven follow-ups (Shreyash0712 on #277, ahmdkaml on #278). Also logs the pr-review-ping.yml path-scoping fix, which wasn't recorded yet.
pyproject.toml's benchmark extra gained matplotlib in #235 (figures.py
needs it to render strategy-comparison PNGs), but cli.py's module
docstring and README's install snippet still listed the old three
packages. Closes #244.