Fix serialization of Dates with expanded ISO years - #232
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid JavaScript Dates outside years 0000–9999 currently throw
Invalid Date ISO stringduring serialization:toISOString()returns a signed six-digit year, but the safety validation accepts only four-digit years.Accept the expanded-year format while retaining the anchored numeric date/time validation. Tests round-trip year -1, year 10000, and both ends of JavaScript's supported Date range. All four regressions fail before the fix; all 104 tests pass afterward, including the existing injection checks.
git diff --checkpasses.The expanded format is specified in https://tc39.es/ecma262/multipage/numbers-and-dates.html#sec-date-time-string-format.