Fix methods containing nested functions and arrows - #231
Open
Shubham-Padkonde wants to merge 2 commits into
Open
Shubham-Padkonde wants to merge 2 commits into
Shubham-Padkonde wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118. The function-kind regexes currently match anywhere in the source, so a concise method containing an arrow or function declaration is returned unchanged. That source is invalid in the generated object-property value and fails to deserialize.
Anchor detection to the outer function signature so concise methods still receive the existing function-expression conversion. Added round-trip cases for nested declarations, destructured arrow arguments, async methods, and generator methods. Additional cases preserve commented async signatures and arrows with function-valued defaults.
Validation: all four new tests fail on the original implementation. All 106 tests pass after the change (
node --test test/unit/*.js);git diff --checkpasses.