refactor: migrate to modern Python project structure with uv#1
Merged
Conversation
- Migrate from requirements.txt to pyproject.toml with uv package manager - Restructure source code into src/probing_reflection/ package - Add comprehensive documentation (AGENTS.md, ARCHITECTURE.md, SPEC.md) - Add test infrastructure with pytest - Add .github/ for CI/CD configurations - Simplify .gitignore for Python/IDE patterns - Remove legacy scripts and placeholder files
Add quick_test.sh and full_test.sh for running validation checks Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Add draft notes for token probe experiment requirements and questions Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Contributor
There was a problem hiding this comment.
6 issues found across 34 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/probing_reflection/types.py">
<violation number="1" location="src/probing_reflection/types.py:42">
P2: The `metadata` dict is mutable despite the class being documented as immutable. `frozen=True` only prevents field reassignment, not in-place mutation of the dict contents. Use `MappingProxyType` or accept an immutable mapping type to enforce true immutability, matching the class's contract.</violation>
</file>
<file name="TEMPLATE.md">
<violation number="1" location="TEMPLATE.md:38">
P2: Package name in rename instructions (`ai_research_template`) doesn't match the actual package name (`probing_reflection`). Users following these steps will get "file not found" errors from both the `sed` and `mv` commands.</violation>
<violation number="2" location="TEMPLATE.md:71">
P2: Wrong file referenced: `packages = ["YOUR_PROJECT_NAME"]` is in `pyproject.toml` line 35, not `AGENTS.md`. This will send users to the wrong file.</violation>
</file>
<file name="SPEC.md">
<violation number="1" location="SPEC.md:23">
P2: `.sisyphus/plans/` and `.sisyphus/roadmap.md` are nested under the `docs/` bullet as if they live inside that directory, but their paths start with `.sisyphus/`, placing them at the repo root. This contradicts AGENTS.md §10 and will mislead agents about where to find these files. Move them to their own top-level bullets.</violation>
</file>
<file name="AGENTS.md">
<violation number="1" location="AGENTS.md:56">
P2: `unknown` is a TypeScript type that does not exist in Python. An agent following this guideline would write invalid code. The Python equivalents to avoid `Any` are `object`, generic type variables (`TypeVar`/`T`), or `Protocol` types.</violation>
<violation number="2" location="AGENTS.md:58">
P2: Python uses `raise`, not `throw`. This is JavaScript/Java terminology that doesn't apply to this Python project.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
There was a problem hiding this comment.
2 issues found across 3 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="scripts/full_test.sh">
<violation number="1" location="scripts/full_test.sh:17">
P3: Step counter is wrong: the first four steps say `/4` but there are 5 steps total. The denominator should be `5` throughout.</violation>
</file>
<file name="scripts/quick_test.sh">
<violation number="1" location="scripts/quick_test.sh:17">
P2: Step counter is wrong: there are 5 steps but the first four say `/4`. Update all labels to `/5`.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
xzAscC
added a commit
that referenced
this pull request
Mar 19, 2026
Fixes 8 issues identified by automated code review: - types.py: Use MappingProxyType for immutable metadata in frozen dataclass - AGENTS.md: Replace TypeScript terminology (unknown) with Python equivalents - AGENTS.md: Replace Throw with Raise, errors with exceptions - TEMPLATE.md: Correct package name from ai_research_template to probing_reflection - TEMPLATE.md: Fix file reference from AGENTS.md to pyproject.toml - SPEC.md: Move .sisyphus/ to top-level (not nested under docs/) - scripts/*.sh: Fix step counters from /4 to /5
Fixes 8 issues identified by automated code review: - types.py: Use MappingProxyType for immutable metadata in frozen dataclass - AGENTS.md: Replace TypeScript terminology (unknown) with Python equivalents - AGENTS.md: Replace Throw with Raise, errors with exceptions - TEMPLATE.md: Correct package name from ai_research_template to probing_reflection - TEMPLATE.md: Fix file reference from AGENTS.md to pyproject.toml - SPEC.md: Move .sisyphus/ to top-level (not nested under docs/) - scripts/*.sh: Fix step counters from /4 to /5
Owner
Author
Contributor
@xzAscC I have started the AI code review. It will take a few minutes to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Added
src/probing_reflection/- Main package with type definitionspyproject.toml- Modern Python packaging with uvtests/- Test infrastructure with pytestscripts/- Development test scriptsquick_test.sh- Fast validation with small modelfull_test.sh- Complete validation across all models.sisyphus/drafts/- Experiment draft notes.github/- Issue templates, PR template, CI workflowdocs/- Quality score tracking and design docsRemoved
Verification
Commits
73c09bd80c246a391b00d