Skip to content

[OPTIMISATION] Cache info-portions checks for actor. - #115

Draft
Neloreck wants to merge 1 commit into
mainfrom
dev/cache-info-poritons
Draft

[OPTIMISATION] Cache info-portions checks for actor.#115
Neloreck wants to merge 1 commit into
mainfrom
dev/cache-info-poritons

Conversation

@Neloreck

@Neloreck Neloreck commented Jul 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Changes

  • Adds lazy caching for actor info-portion checks.
  • Updates the cache on scripted grants, disables, and engine callbacks.
  • Replaces ACTOR_INFO_UPDATE with ACTOR_INFO_ADDED and ACTOR_INFO_REMOVED.
  • Registers and unregisters the inventory_info_removed actor callback.
  • Updates registry fixtures and affected tests.

Checklist

  • tests are included

Links / references

Blocked by OpenXRay/xray-16#2114

@Neloreck Neloreck self-assigned this Jul 12, 2026
@github-actions github-actions Bot added cli Changes are affecting XRF cli tools test Changes are updating or introducing unit tests managers Changes are affecting game managers schemes Changes are affecting game logics schemes labels Jul 12, 2026
@Neloreck
Neloreck force-pushed the dev/cache-info-poritons branch from c8ab452 to 6783604 Compare July 12, 2026 00:44
@Neloreck Neloreck removed the cli Changes are affecting XRF cli tools label Jul 12, 2026
@codecov

codecov Bot commented Jul 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.42%. Comparing base (e2a78d3) to head (87440ca).

Files with missing lines Patch % Lines
src/engine/core/binders/creature/ActorBinder.ts 66.66% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   72.40%   72.42%   +0.01%     
==========================================
  Files        1093     1093              
  Lines       33770    33795      +25     
  Branches     5780     5781       +1     
==========================================
+ Hits        24452    24475      +23     
- Misses       9318     9320       +2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Neloreck
Remove unused $inline import from info_portion.ts.
87440ca 
Update `EventsManager` test to reflect callback size increase from 126 to 127.
Refactor actor info-portions logic: rename events, add granular callbacks.
Add caching and callbacks for info portions state tracking.
@Neloreck
Neloreck force-pushed the dev/cache-info-poritons branch from 6783604 to 87440ca Compare July 14, 2026 17:06
@Neloreck Neloreck changed the title [OPTIOMISATION] Cache info-portions checks for actor. [OPTIMISATION] Cache info-portions checks for actor. Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Neloreck Neloreck

Labels

managers Changes are affecting game managers schemes Changes are affecting game logics schemes test Changes are updating or introducing unit tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Neloreck