Repository navigation
Release 1.3.0: take the version from the git tag - #45
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Fetch the git history in the publish jobs so the tag is available - Build the Linux wheels from the sdist, which carries the version - Refuse to upload wheels whose version doesn't match the release tag - Document the release process Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
elazarcoh
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The package version now comes from the latest
vX.Y.Zgit tag, so releasing only takes publishing a GitHub release. There's no version to bump in the code anymore.Publishing a
v1.3.0release after this is merged produces 1.3.0, the release that adds Python 3.14 and free-threaded 3.14t support (#44).How it works
tools/version.pycomputes the version:X.Y.Z.X.Y.(Z+1).devN+g<hash>..versionfile.0.0.0.dev0.meson.buildtakes the project version from that script. A meson dist script writes.versioninto every sdist, since sdists have no git history.__version__is generated at build time (src/extype/_version.py.in→extype/_version.py).Publish workflow
fetch-depth: 0, so the release tag is available.python -m build.workflow_dispatchrun from a branch now fails at this step; run it from a tag instead.Testing
Locally on Windows:
1.2.1.dev14+g90d64db. The sdist contains.version, and the wheel built from that sdist has the same version.v1.3.0tag (deleted afterwards, never pushed), the sdist and wheels build as1.3.0. That includescibuildwheelbuildingextype-1.3.0-cp314-cp314t-win_amd64.whlfrom the sdist.0.0.0.dev0, so PR test runs keep working.extype.__version__matches the build.Not verified: the Linux cibuildwheel run inside Docker. The publish workflow only runs on a release.
🤖 Generated with Claude Code