0.2.1#4
Merged
Merged
Conversation
… command The server renamed the "Show references" CodeLens command from the VS Code-internal `editor.action.showReferences` to a neutral `xphp.showReferences`. Update the client-side LspCommandsSupport interceptor (and docs) to match so lens clicks keep opening the native usage popup. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The LSP provides semantic-token highlighting, so the bundled TextMate grammar bootstrap was redundant (and the grammar resource was never actually packaged). Drop it entirely: - Delete XphpBundleRegistrar + its test and the postStartupActivity wiring - Drop the org.jetbrains.plugins.textmate <depends> and the intellij.textmate module dependency (plugin.xml, build.gradle.kts, platformBundledPlugins) - .xphp files now open as plain text and are routed to the LSP by extension; highlighting comes from the server's semantic tokens - Refresh comments/docs that described the TextMate path Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add an optional xphpLspPharSha256 input to the downloadLspPhar task: it verifies the downloaded phar against a pinned checksum (failing the build on mismatch) and tracks the sha as a second build input. That closes the gap the URL alone can't -- a release re-published at the SAME version URL with new bytes now forces a re-download instead of staying UP-TO-DATE. Point xphpLspPharUrl at the v0.2.2 release and pin its sha256. v0.2.2 also fixes the embedded serverInfo version the status bar reports. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Map each LSP semantic-token type directly onto PhpHighlightingData keys so .xphp code is colored exactly like PHP in whatever color scheme is active (stock, New UI, "Islands", or user-customized) and follows any edit the user makes to PHP's colors. Token modifiers pick the right PHP key: static vs instance field/method-call, and declaration vs call for functions. This replaces the earlier approach of custom XPHP_* attribute keys whose colors were seeded via per-scheme additionalTextAttributes for "Default" and "Darcula" only -- that regressed to black on any other scheme (the seed attaches by exact scheme name) and never matched the user's PHP colors. The now-obsolete XphpColors, XphpColorSettingsPage, colorSchemes/*.xml, and their plugin.xml registrations are removed (those files were untracked). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Point xphpLspPharUrl at the v0.2.3 release and update the pinned sha256 (ee22d54...) so the build fetches and verifies the new asset. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.