deps: bump webbrowser to 1.2.4 to fix RUSTSEC-2026-0257 (CI audit failure) - #63
Merged
Conversation
cargo audit fails the CI "Format and audit" job on RUSTSEC-2026-0257: webbrowser 1.2.1 allows browser-argument injection via the Unix BROWSER env var (fixed in 1.2.2). Bump the locked version to 1.2.4, which stays within the existing "1" requirement in Cargo.toml. Lockfile-only change. The remaining lru 0.18.0 unsound advisory (RUSTSEC-2026-0253) is a transitive dep of ratatui-core and only a warning; cargo audit exits 0. Co-authored-by: xJoker <xjoker@users.noreply.github.com>
xjoker
marked this pull request as ready for review
August 25, 2026 23:43
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CI Format and audit job (
cargo audit) is failing ondevand on every open PR:This is a pre-existing dependency advisory (published 2026-07-29), unrelated to any feature branch — it fails the audit job for all PRs including the Dependabot ones.
Fix
cargo update -p webbrowser→ 1.2.1 → 1.2.4, which stays within the existingwebbrowser = "1"requirement inCargo.toml. Lockfile-only change (also pulls in transitiveobjc2-app-kit/objc2-core-foundation/dispatch2bumps that webbrowser 1.2.4 requires on macOS).Verification (Linux)
cargo build— OKcargo audit— now exits 0:The remaining
lru 0.18.0unsound advisory (RUSTSEC-2026-0253) is a transitive dep ofratatui-coreand only a warning — CI runs plaincargo audit(no--deny warnings), so it does not fail the job. Fixing it requires an upstreamratatuirelease and is out of scope here.Note
Once this merges to
dev, the audit job on other open PRs (e.g. #62 and the Dependabot bumps) will pass on re-run, sincepull_requestCI checks out the PR merged intodev.