Repository navigation
chore(audit): accept the unfixed braces advisory GHSA-vfj7-8cjw-p6xm - #1496
Merged
Merged
Conversation
The npm-audit gate fails every PR on a braces advisory published 2026-09-18. It affects braces <=3.0.3, the latest release, and lists no patched version, so no upgrade can clear it. braces reaches the shipped tree only through the content server's @slidev/cli (vite-plugin-static-copy>chokidar@3 and fast-glob>micromatch), which globs Slidev's own patterns. The content server's watcher uses chokidar@5, which does not depend on braces. The worst case is a stack-overflow crash of the local Slidev preview for a deck the user opened.
11 of 16 tasks
newhdr
pushed a commit
to newhdr/vmark
that referenced
this pull request
Oct 5, 2026
# Conflicts: # scripts/npm-audit-baseline.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The npm-audit gate (
scripts/check-npm-audit.mjs, infe-static) fails every PR,mainincluded, on abracesadvisory published 2026-09-18: GHSA-vfj7-8cjw-p6xm (high, stack-exhaustion DoS through deeply nested patterns). It affectsbraces <= 3.0.3, the latest release, and lists no patched version, so no dependency upgrade can clear it. This adds it to the reviewed baseline with its reachability written down.Blocks #1495 (its
frontendcheck is red only on this step).Policy Gates (Required)
Linked Issue
Type of Change
What Changed
scripts/npm-audit-baseline.json: acceptGHSA-vfj7-8cjw-p6xmwith a reason.Reachability (
pnpm why braces -r --prod):server/content>@slidev/cli>vite-plugin-static-copy>chokidar@3, andfast-glob>micromatch. Those glob Slidev's own patterns.server/content/src/index/watch.ts) useschokidar@5, which does not depend onbraces.globby,markdownlint-cli2) are dev tooling.Same shape as the existing
GHSA-w3rx-r6r6-pgprentry (unfixed, same Slidev chain). The gate is two-way, so this entry fails CI once the advisory is withdrawn or fixed, and must be removed then.Validation
pnpm check:alllocally.node scripts/check-npm-audit.mjsexits 1 before the change and 0 after;scripts/check-baseline-ratchet.mjsholds. No app behavior changes.UI Evidence (if applicable)
N/A
PR Checklist