fix(proxy): allow X-* headers in CORS preflight and report real version - #190
Open
BlessedWithLuck1105 wants to merge 2 commits into
Open
fix(proxy): allow X-* headers in CORS preflight and report real version#190BlessedWithLuck1105 wants to merge 2 commits into
BlessedWithLuck1105 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
managementApiPortwas defined in the shared config types, preload bridge, and renderer settings, but the code that builds the local management API URL always usedproxyPort. This made the field a dead config value.This PR makes the local management API URL resolve
managementApiPortfirst and fall back toproxyPortwhen it is unset. The settings page now shows the same effective endpoint, so the UI and preload bridge stay in sync.How did you verify your code works?
node --test tests/renderer/header-proxy-address.test.mjsnpm run check:source-artifactsbun --cwd packages/opencode typecheckScreenshots / recordings
Not a UI change.
Checklist