feat: add implementation/support for oh-my-pi (omp)#631
Merged
Conversation
xenodium
requested changes
Jun 7, 2026
xenodium
left a comment
xenodium
left a comment
Owner
There was a problem hiding this comment.
Thanks for the PR!
Left a few minor comments. Mind taking a look? Also, we should update the README.org file with similar information as the others.
| :welcome-function #'agent-shell-omp--welcome-message | ||
| :client-maker (lambda (buffer) | ||
| (agent-shell-omp-make-client :buffer buffer)) | ||
| :install-instructions "Install omp (Oh My Pi) and ensure it is available on your PATH.")) |
Owner
There was a problem hiding this comment.
We should follow the same patterns as others and include a URL
Something like (if that's the right location):
"See https://github.com/can1357/oh-my-pi for installation."
|
|
||
| (setq agent-shell-omp-environment | ||
| (agent-shell-make-environment-variables | ||
| \"ANTHROPIC_API_KEY\" \"your-key\"))" |
Owner
There was a problem hiding this comment.
Is ANTHROPIC_API_KEY relevant for this agent? If not, we should try to show a relevant variable if possible
Contributor
Author
There was a problem hiding this comment.
It definitely can be, depending on what backend or backends you use with the agent.
To be less confusing I'll change this to just and
Owner
|
Thanks for the changes. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #630, support for omp agent. Been using it for a bit, and it seems to work. 🤷.
Didn't want to keep it to myself, and I hope it's useful to other people.
(agent shell is great!)
Checklist
M-x checkdocandM-x byte-compile-file.