Refactoring 2026 09 - #4
Merged
Merged
Conversation
Update the map screen refactoring plan with the audit's composition-root checklist and current progress, mark completed audit findings in the audit report, fix the outdated storage-permission and export-format docs, regroup the documentation index, and add .dsh/doc-impact.yml mapping source areas to the documents they affect. Personal overrides are git-ignored and the plugin workflow is documented in AGENTS.md.
Drop noisy doc-impact links (settings glob to the quick-start, model barrel to export docs, CI to AGENTS.md, ARB churn to the dated localization spec) and keep only precise code-to-document mappings. Add coverage for the Carpeater guide, the fresh-session design spec, and the fork changelog draft. Document Carpeater mode - the largest fork feature without docs - mark the upstream MQTT authentication guide as removed in this fork, and mention the database backup in the quick start.
Write six user guides grounded in the changelog and code: recording sessions, markers and zones, positioning and location quality, data management, online coverage features (uploads, community coverage, offline tiles, connectivity), and analytics with achievements. Extend the doc-impact config with rules for the new guides, cross-link them from the documentation index and the quick start, and note the double-tap quick-settings and long-press add-menu map gestures there. Documented behavior follows the code: privacy zones filter uploads only, not sample exports.
Sample exports (JSON, CSV, GPX, KML) now drop samples inside privacy zones the same way uploads already did, so shared files never contain them. The SQLite database backup stays a complete snapshot by design - it is the only export that keeps privacy-zone data. Export snackbars and share texts report the filtered sample count. The zone-containment and filtering logic becomes testable static helpers with unit tests, and the dead isInPrivacyZone point check is removed. Guides updated to document the new policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.