CA-430005: Should not check non-trusted certificates for duplication#7188
Merged
Merged
Conversation
The duplication check should be applied to trusted certificates only. Signed-off-by: Ming Lu <ming.lu@cloud.com>
changlei-li
reviewed
Jul 22, 2026
| And (type', fingerprint_sha256) | ||
| in | ||
| Db.Certificate.get_records_where ~__context ~expr | ||
| |> List.filter (fun (_, cert_rec) -> cert_rec.API.certificate_name = "") |
Contributor
There was a problem hiding this comment.
This line is removed. Is it intentional?
Member
Author
There was a problem hiding this comment.
Yes. All trusted certificates are of name = "".
minglumlu
force-pushed
the
private/mingl/CA-430005
branch
from
July 22, 2026 07:02
b38529b to
eb746b7
Compare
changlei-li
approved these changes
Jul 22, 2026
cplaursen
approved these changes
Jul 23, 2026
Merged
via the queue into
xapi-project:master
with commit Jul 24, 2026
4b9b9aa
18 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The duplication check should be applied to trusted certificates only.