CA-428461: make trusted-domain attribute enrichment best-effort#7126
Open
liulinC wants to merge 1 commit into
Open
CA-428461: make trusted-domain attribute enrichment best-effort#7126liulinC wants to merge 1 commit into
liulinC wants to merge 1 commit into
Conversation
liulinC
force-pushed
the
private/linl/CA-428461
branch
2 times, most recently
from
de76c98 to
900b816
Compare
Fold Wbinfo.kdc_of_domain (wbinfo --getdcname) into the same match as Ldap.query_user in query_subject_information_user, so a DC-location or LDAP query failure falls back to default_account instead of aborting subject creation via let*. Fixes subject-add for one-way trusted-domain users when getdcname cannot locate the trusted DC; attributes are refreshed later by update_all_subjects. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Lin Liu <Lin.Liu01@cloud.com>
liulinC
force-pushed
the
private/linl/CA-428461
branch
from
900b816 to
d57c84d
Compare
psafont
approved these changes
Jun 12, 2026
changlei-li
reviewed
Jun 12, 2026
changlei-li
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fold Wbinfo.kdc_of_domain (wbinfo --getdcname) into the same match as Ldap.query_user in query_subject_information_user, so a DC-location or LDAP query failure falls back to default_account instead of aborting subject creation via let*. Fixes subject-add for one-way trusted-domain users when getdcname cannot locate the trusted DC; attributes are refreshed later by update_all_subjects.