VLAN filtering on VIF#7123
Open
semarie wants to merge 2 commits into
Open
Conversation
Use a more generic message to permit to use it in other context than VLAN creation. Signed-off-by: Sebastien Marie <semarie@kapouay.eu.org>
semarie
force-pushed
the
dev/srt/master/vlan-filtering
branch
from
32d343e to
013dff3
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
semarie
force-pushed
the
dev/srt/master/vlan-filtering
branch
from
013dff3 to
3b3f2b5
Compare
semarie
force-pushed
the
dev/srt/master/vlan-filtering
branch
3 times, most recently
from
54e858c to
f62adbe
Compare
semarie
force-pushed
the
dev/srt/master/vlan-filtering
branch
from
f62adbe to
86df0ef
Compare
psafont
reviewed
Jun 11, 2026
psafont
reviewed
Jun 11, 2026
| with_xc_and_xs (fun xc xs -> | ||
| match vif.backend with | ||
| | Network.Sriov _ -> | ||
| raise (Xenopsd_error (Unimplemented "network SR-IOV")) |
Member
There was a problem hiding this comment.
I would rather return NOT_SUPPORTED, using unimplemented might give the idea that it's meant to be implemented
Contributor
Author
There was a problem hiding this comment.
I see no not_supported (or approx) error in api_errors.ml. Maybe value_not_supported ?
Also, other code treating Network.Sriov as error in ocaml/xenopsd/xc/xenops_server_xen.ml are using Unimplemented (like move, set_locking_mode, set_pvs_proxy).
psafont
approved these changes
Jun 11, 2026
psafont
requested changes
Jun 11, 2026
- update idl/datamodel to add trunks property on VIF - add validation constraints (trunks filtering on access port isn't valid) - add support inside `vif-real` for initial configuration - add support inside xenopsd for dynamic changes - add test coverage to new attributes References: - Design document: https://github.com/xapi-project/xen-api/blob/788869e5a92e10332ba2428eb91e5a2caf4c7131/doc/content/design/vlan-filtering.md Signed-off-by: Sebastien Marie <semarie@kapouay.eu.org>
semarie
force-pushed
the
dev/srt/master/vlan-filtering
branch
from
86df0ef to
ccb6e9d
Compare
psafont
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vif-realfor initial configurationReferences:
Internal references: