Repository navigation
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Reproducible real-site examples for automatic CRL retrieval at The key output lines below were verified by this commit's seven passing live BadSSL checks when the stack was split. Fresh manual captures on 2026-10-08 encountered TLS connection resets/timeouts from this environment, so these are tested expected excerpts, not a fresh stdout capture. Build this PR: gh pr checkout 546
cargo build --locked
ICC="$PWD/target/debug/inspect-cert-chain"A revoked leaf: "$ICC" --host revoked.badssl.com --timeout 30s --fields subjectA valid control: "$ICC" --host sha256.badssl.com --timeout 30s --fields subjectThe live checks verified exit code CRL retrieval uses up to five seconds within the fetch deadline. If the CRL service is unavailable or its data cannot be verified, revocation reports To repeat all seven live assertions: just test-badsslThe excerpts omit other certificate and validation lines. Public certificates and CRLs change over time, and the valid result depends on the CRL service being reachable. |
When no CRL file is supplied, download leaf CRLs from HTTP or HTTPS distribution points. Use the configured system and custom roots for HTTPS.
Limit retrieval to eight URLs, 10 MiB per response, and five seconds within the fetch deadline. Report unavailable or unverified revocation data as UNKNOWN while preserving inspection and
--dump. Local checks remain offline, and supplied CRL files take precedence.This is layer 4 of 4. Includes local HTTP tests for revoked certificates, invalid signatures, unavailable services, and delayed responses, plus the live revoked BadSSL check.
Validation on macOS:
just test(85 passed),nix develop -c just check(formatting and Clippy passed), andjust test-badssl(7 passed).