Skip to content

fix: update workspace lockfile with macro pin - #514

Merged
robjtede merged 1 commit into
mainfrom
t3code/investigate-release-merge-failure
Oct 5, 2026
Merged

robjtede merged 1 commit into
mainfrom
t3code/investigate-release-merge-failure

Conversation

@robjtede

@robjtede robjtede commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Update the workspace lockfile after changing the macro dependency pin.
  • Stage both the manifest and workspace lockfile in the pin update script.
  • Check out the target PR before comparing the current pin.

Testing

  • Not run

Summary by CodeRabbit

  • Chores
    • Automated pull request updates now keep the workspace lockfile in sync with the updated manifest pin.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 48 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0bba943c-b077-4936-979a-d3c9908a5499
📥 Commits

Reviewing files that changed from the base of the PR and between 2e9fffa and 8640ed1.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • scripts/update-macro-pin

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fe9555ac-226b-4be3-9c7c-82ef348052ee
📥 Commits

Reviewing files that changed from the base of the PR and between 6ebe52a and 2e9fffa.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • scripts/update-macro-pin

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The script now checks out a target PR before reading its manifest pin. After changing the pin, it updates the Cargo workspace and stages the target manifest and workspace Cargo.lock for a PR change.

Changes

Macro pin update

Layer / File(s) Summary
Update and stage the workspace pin
scripts/update-macro-pin
When PR_NUMBER is nonempty and not "null", the script checks out that PR before reading the manifest pin. It then runs cargo update --workspace, gets the workspace root from Cargo metadata, and stages the target manifest and workspace Cargo.lock for the PR change.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 2e9ff

The change reads the target PR’s pin and stages its corresponding workspace lockfile. No concrete merge-blocking risk is established.

Architecture Summary

Architecture risk: 🔵 Low · up to 2e9ff

The change affects 1 system.

Changed systems: scripts

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — scripts (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in scripts/update-macro-pin: The conditional PR checkout moved here, before the script reads the current manifest pin; it was removed from its former location after the pin update.
  • observed — Modified behavior in scripts/update-macro-pin: After updating the manifest pin, the script runs a workspace-wide Cargo update against the target manifest and retrieves the workspace root from Cargo metadata.
  • observed — Modified behavior in scripts/update-macro-pin: When handling a PR, the staged files now include the workspace-root Cargo.lock in addition to the target manifest.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: updating the workspace lockfile when the macro pin changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@robjtede
robjtede force-pushed the t3code/investigate-release-merge-failure branch from 2e9fffa to 8640ed1 Compare October 5, 2026 17:09
@robjtede
robjtede enabled auto-merge October 5, 2026 17:10
@robjtede
robjtede added this pull request to the merge queue Oct 5, 2026
Merged via the queue into main with commit 9229dfc Oct 5, 2026
9 checks passed
@robjtede
robjtede deleted the t3code/investigate-release-merge-failure branch October 5, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant