time cross platform#365
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (3)
Walkthrough将 Changes计时函数重构
Sequence Diagram(s)sequenceDiagram
participant ComponentA
participant ComponentB
ComponentA->>ComponentB: observable interaction
估计代码审查工作量🎯 3 (Moderate) | ⏱️ ~20 minutes 可能相关的 PR
小诗
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/time.cpp`:
- Around line 185-189: The timing baseline in the time utility uses
high_resolution_clock, which may not be monotonic and can break
delay_fps/delay_jfps behavior if system time changes. Update the logic in the
time-related function that defines start_time_point and computes durationTime to
use std::chrono::steady_clock consistently for both the stored start point and
the current timestamp, so frame pacing and FPS measurements are based on a
stable clock.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 05875eb0-ce51-45b3-b3f9-aae2cb71e875
📒 Files selected for processing (4)
src/ege_head.hsrc/ege_time.hsrc/egegapi.cppsrc/time.cpp
💤 Files with no reviewable changes (1)
- src/ege_head.h
ac4a8db to
c37e1f6
Compare
整个src中没有对get_highfeq_time_start的其它引用,可以安全地删除
运行所有demo都没发现有问题
Summary by CodeRabbit