sdk: split translator test files to match the source layout - #402
Merged
Conversation
Pure moves: per-area test files mirror the split source files; shared test helpers land in helpers_test.go, cross-shape composition tests in e2e_test.go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the decomposition series (#400, #401) on the test side — pure moves, identical test counts verified (anthropic 88, openai 149, gemini 41):
anthropic/translator_canonical_test.go(2598) → per-area files mirroring the source split (request_parse/request_serialize/response/stream_to_canonical/stream_from_canonical), plushelpers_test.go(shared builders) ande2e_test.go(cross-shape composition).openai/translator_cc_test.go(1901) →cc_request_parse/cc_request_serialize/cc_response/cc_streamtests; shared helpers →helpers_test.go.openai/translator_responses_test.go(2143) →responses_request_canonical/responses_items_canonical/responses_response_canonical/responses_streamtests; the two cross-shape E2E tests →e2e_test.go.Largest test file is now 1056 lines. Stacked on #401.