Fixed easy issues with some demos to get them working again. - #20
Open
calconst wants to merge 1 commit into
Open
Fixed easy issues with some demos to get them working again.#20calconst wants to merge 1 commit into
calconst wants to merge 1 commit into
Conversation
Easy issues include invalid syntax, invalid imports, floor division versus true division, and method call signature changes. This does not necessarily mean the behavior of the demo is correct (although most are), rather they no longer raise exceptions when using them from the demos application.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Easy issues include invalid syntax, invalid imports, floor division versus
true division, and method call signature changes. This does not necessarily
mean the behavior of a fixed demo is correct, rather the demo no
longer raise exceptions when it's used from the demos application.
This includes changes to some demo sources and some library sources.