Repository navigation
Conversation
Drupal's scaffold writes web/.eslintrc.json, which extends core's ESLint config and needs eslint-plugin-jsdoc. The template doesn't install that plugin, so npm run lint fails in every project made from the template. #246 hit the same root cause with eslint-plugin-yml. The root .eslintrc.json now applies to custom code. Claude-Session: https://claude.ai/code/session_012FKaDB3ZoovhEYXdXSdiUT
DDEV's MariaDB defaults to REPEATABLE READ. Parallel Playwright workers creating nodes deadlock on node_field_data gap locks, so the article test fails intermittently. #352 set READ-COMMITTED for Lando only, and the setting was lost in the move to DDEV. Setting it on the connection covers every environment and matches the Silta MariaDB config. Claude-Session: https://claude.ai/code/session_012FKaDB3ZoovhEYXdXSdiUT
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
🔵 Needs a closer look
The changes affect project scaffolding and database behavior and require final human validation.
0 open findings
What changed in this PR
Fixes fresh-project lint failures and Playwright deadlocks by updating scaffolding and database isolation settings.
Changes:
- Prevents scaffolding of the conflicting ESLint configuration.
- Configures
READ COMMITTEDisolation for parallel tests.
| File | Description |
|---|---|
composer.json |
Prevents scaffolding the conflicting ESLint configuration. |
Files excluded by content exclusion policy (1)
- web/sites/default/settings.php
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket GH-481
Fixes #481
Changes
web/.eslintrc.json. It extends core's ESLint config, which needseslint-plugin-jsdoc, sonpm run lintfails on every fresh project. Same root cause as Error: ESLint couldn't find the plugin "eslint-plugin-yml" #246.'isolation_level' => 'READ COMMITTED'insettings.php. Under DDEV's defaultREPEATABLE-READ, parallel Playwright workers deadlock onnode_field_datainserts. Change DB transaction_isolation to READ-COMMITTED #352 fixed this for Lando only, and it was lost in the move to DDEV.The Playwright Tests workflow should run again on this PR.
ddev/github-action-setup-ddevwas added to the org Actions allowlist, which removes thestartup_failureevery run has had since mid-September.Testing
Enviroment: local DDEV (no deploy needed, the changes are local tooling and DB connection settings)
Login:
ddev drush uliInstructions:
ddev composer install, then confirmweb/.eslintrc.jsonis not created (delete an existing one first)ddev npm run lint:jspassesddev drush php:eval 'echo \Drupal::database()->query("SELECT @@transaction_isolation")->fetchField();'printsREAD-COMMITTEDddev exec npx playwright testpasses all 7 tests on repeated runs. Before the fix, the article test failed withSQLSTATE[40001] ... Deadlock found.Verified the same changes in wunderio/internal-mearra-main-data-system: lint passes, Playwright 7/7 over 3 consecutive runs.
https://claude.ai/code/session_012FKaDB3ZoovhEYXdXSdiUT