Make ionization and recombination components functions, optionally return level-resolved rates - #444
Draft
wtbarnes wants to merge 7 commits into
Draft
Make ionization and recombination components functions, optionally return level-resolved rates#444wtbarnes wants to merge 7 commits into
wtbarnes wants to merge 7 commits into
Conversation
wtbarnes
force-pushed
the
density-dependent-rates
branch
from
May 7, 2026 22:07
ee238fc to
50bc8a3
Compare
Owner
Author
|
Some working notes for myself
|
Owner
Author
|
There are properties related to the older treatment of the level-resolved ionization and recombination rate data (cilvl and reclvl files, respectively) that I've called Lines 997 to 1019 in 43ad865 These should just be folded into the Line 1022 in 43ad865 These are not meant to be used on their own and should not be confused with the new advanced model data. |
… optionally density-dependent
wtbarnes
force-pushed
the
density-dependent-rates
branch
from
July 31, 2026 17:23
50bc8a3 to
80ac468
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #384
Fixes #385
Fixes #415
Fixes #416
Remaining TODOs
Element.ionization_equilibriumto accept a density and atmosphere model.