Skip to content

docs(licenses): list three.js, ReScript runtime, PuzlWerk viewer and Core - #65

Merged
wstein merged 4 commits into
mainfrom
docs/licenses-page-third-party
Nov 18, 2026
Merged

wstein merged 4 commits into
mainfrom
docs/licenses-page-third-party

Conversation

@wstein

@wstein wstein commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Purpose: the third-party license page names components that the capture-review spike (#64) bundles and the vendored PuzlWerk archives carry. Owner decision 2026-11-17: PuzlWerk Core is EUPL-1.2 OR AGPL-3.0-or-later.

Changes:

  • public/licenses/index.html: entries for three.js (MIT), @rescript/runtime (MIT), @puzlwerk/viewer (AGPL-3.0-or-later) and PuzlWerk capture recovery: the vendored 0.3.0 archive (EUPL-1.2 only, with CubeAssembler-derived MIT material) first, then the Core license EUPL-1.2 OR AGPL-3.0-or-later from 2026-11-17 on (0.1.0 and 0.3.0 stay EUPL-1.2).
  • License texts next to the page: three.LICENSE (three 0.187.0, from the spike checkout, because main does not install three), rescript-runtime.LICENSE, agpl-3.0.LICENSE (identical to LICENSE), eupl-1.2.LICENSE (from the 0.3.0 archive).
  • test/thirdPartyLicenses.test.ts: each entry names its license and links a text pinned by SHA-256; all .LICENSE links exist; the capture-recovery entry states EUPL-1.2 first, both licenses, the AGPL link and the MIT note.

Merge order: three.js and the viewer are bundled only with #64; merge this PR together with or after it.

Tests (Node 22.23.4): thirdPartyLicenses 6 pass, with projectLicense 10 pass; format:check, lint:typescript, tsc --noEmit, typos, build pass, git diff --check clean. Mutations fail: entry removed, license name changed, link target renamed, 0.3.0 statement changed, texts truncated or altered, AGPL link removed, MIT note removed.
Not verified: the @rescript/runtime package ships no license file; the MIT text is that of the rescript package (LICENSE.MIT). No legal assessment.

Blocker: owner acceptance of the license wording
Refs #64, wstein/puzlwerk#91

🤖 Generated with Claude Code

wstein and others added 2 commits November 17, 2026 23:05
…lWerk viewer and Core

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… and capture recovery

Capture recovery is EUPL-1.2 OR AGPL-3.0-or-later from 2026-11-17; the vendored 0.3.0 archive stays EUPL-1.2 only. A test checks entries, links and license texts.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@wstein

wstein commented Nov 17, 2026

Copy link
Copy Markdown
Owner Author

Review: FINDINGS head=870026bb9ba26470c26185249b4beea65473270f patch-id=c6ca842e553a597a5163aaa5e7b8101de1f34262 pr=65
blocking test/thirdPartyLicenses.test.ts:19,25,31,37,55: the text check matches only the header line, so a truncated or altered license text passes (eupl-1.2.LICENSE cut to 20 of 190 lines, three.LICENSE cut to its first 4 lines, three.js copyright line replaced: all 10 tests pass). Pin each file by SHA-256 as test/projectLicense.test.ts does: three 8b378ebe60e2fe500158cb0ac71cb5e8b7d92953c2abcc63a0eb90499653b5bc, rescript-runtime 5fb9a2cbdb422b4bf31100b9208d661ab9abf96d33c137e8d3755f2626d0b83b, agpl-3.0 0d96a4ff68ad6d4b6f1f30f713b18d5184912ba8dd389f86aa7710db079abcb0, eupl-1.2 57fb42fbcd0b037ce528ed8f72f1ec095d67bc6825ecf1448ff39be1fe68a4b4.
nit public/licenses/index.html:31-35: main ships the 0.3.0 archive (EUPL-1.2 only); leading with the dual license can read as applying to the shipped copy. Consider naming the shipped archive and its license first.
nit public/licenses/index.html:33: removing the AGPL link in the capture-recovery entry passes all tests.
nit public/licenses/index.html:31-35: the 0.3.0 archive also carries CubeAssembler-derived MIT material (CUBE_ASSEMBLER_LICENSE.txt, vendor/README.md); the entry does not mention it.
nit public/licenses/index.html:22,27-30: three.js and @puzlwerk/viewer are not bundled on main until #64; the PR text states this.
Verified: three.LICENSE byte-identical to three@0.187.0 LICENSE; rescript-runtime.LICENSE byte-identical to rescript@12.3.1 LICENSE.MIT, whose LICENSE index assigns packages/@rescript/runtime/ to MIT; agpl-3.0.LICENSE equals LICENSE; eupl-1.2.LICENSE equals package/LICENSE of the vendored 0.3.0 archive. Statements match the 0.3.0 NOTICE and wstein/puzlwerk#91 NOTICE files.
Runs (Node 22.23.4, archive copy): npm ci ok; vitest thirdPartyLicenses+projectLicense 10/10; format:check, lint, tsc --noEmit, typos, build pass; dist/licenses holds all four texts; git diff --check clean.
Mutations: 12 run; 8 fail at the intended test (entry removed, license name changed, link renamed, 0.3.0 sentence removed or changed, dual license removed, AGPL text replaced); 4 survive (3 text, 1 link above). Test fails 5/6 at dd62ef1 (test first).
CI run 44196307421 at this head: test and typos success; no .github changes. Commits: Conventional, author and committer match git config, Co-Authored-By present, no CRLF, no session links. PR text 15 lines with Blocker line.

wstein and others added 2 commits November 17, 2026 23:32
…-derived material

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…e-recovery entry

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@wstein

wstein commented Nov 17, 2026

Copy link
Copy Markdown
Owner Author

Review: CLEAR head=ca5c43730b619288d8a9f642699a38a52e384554 patch-id=06a381563cf04acf0c7eaa09b6bb7a602c15a6b2 pr=65
Round 2, delta against 870026b (normal push, two new commits).
Round 1 blocking resolved: test/thirdPartyLicenses.test.ts pins all four texts by SHA-256; pins recomputed and equal to the files, which match three@0.187.0 LICENSE, rescript@12.3.1 LICENSE.MIT, LICENSE and package/LICENSE of the vendored 0.3.0 archive. Truncated EUPL, truncated three.js text, changed three.js and ReScript copyright lines now fail.
Round 1 nits resolved: the capture-recovery entry leads with the shipped 0.3.0 archive (EUPL-1.2), then the Core dual license; the AGPL link is tested; the MIT note matches vendor/README.md and CUBE_ASSEMBLER_LICENSE.txt in the 0.1.0 and 0.3.0 archives (both EUPL-1.2 in package.json); the PR text names the merge order with or after #64.
nit test/thirdPartyLicenses.test.ts:79: only the file name CUBE_ASSEMBLER_LICENSE.txt is checked; removing the sentence about CubeAssembler-derived MIT material but keeping the file name passes.
nit commit 8dc0d74: the HTML change precedes the test update, so thirdPartyLicenses fails 1/6 at that commit (green again at ca5c437).
Mutations: 14 run, 13 fail at the intended test, 1 survives (nit above).
Runs (Node 22.23.4, archive copy): npm ci ok; vitest thirdPartyLicenses+projectLicense 10/10; format:check, lint, tsc --noEmit, typos, build pass; dist/licenses holds all four texts and the page; git diff --check clean.
CI run 44200340679 at this head: success; no .github changes. Commits: Conventional, author and committer match git config, Co-Authored-By present, no CRLF, no session links. PR text 17 lines with Blocker line, @ tokens in backticks.

@wstein
wstein marked this pull request as ready for review November 18, 2026 08:42
@wstein
wstein merged commit b1da0c6 into main Nov 18, 2026
2 checks passed
@wstein
wstein deleted the docs/licenses-page-third-party branch November 18, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant