Skip to content

chore(license): relicense CubeAssembler to AGPL-3.0-or-later - #63

Merged
wstein merged 5 commits into
mainfrom
chore/relicense-agpl
Nov 17, 2026
Merged

wstein merged 5 commits into
mainfrom
chore/relicense-agpl

Conversation

@wstein

@wstein wstein commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Purpose: relicense CubeAssembler from MIT to AGPL-3.0-or-later. Owner decision 2026-11-17: #29 (comment) (the owner is the copyright holder). Reason: the PuzlWerk viewer (AGPL-3.0-or-later) is to be consumed directly.

Head: 96e32f7
Changes:

  • LICENSE: verbatim https://www.gnu.org/licenses/agpl-3.0.txt, sha256 0d96a4ff68ad6d4b6f1f30f713b18d5184912ba8dd389f86aa7710db079abcb0.
  • package.json and package-lock.json root license, README badge and section, CONTRIBUTING clause, AGENTS.md sentence (with dated owner decision).
  • test/projectLicense.test.ts (4 tests: package.json, lockfile root, LICENSE hash, own-license statements). No SPDX headers exist; vendor/ and third-party licenses unchanged.

Tests: lockfile test failed against 2a9e34e (1 of 4); mutations (LICENSE truncated, lockfile MIT, AGENTS.md GPL-2.0-only, LICENSE line 1 MIT, package.json MIT) each fail the intended test. typecheck, lint, format:check, typos: exit 0. npm test: 1386 passed, 47 failed (fixtures, liveFaceAppearance, gridAlignmentRealCrops: LFS pointers, no git-lfs locally). Not verified: LFS suites, e2e.

Findings: Claude/Codex co-authored commits and 35 dependabot commits; vendored capture-recovery 0.3.0 is EUPL-1.2 (Appendix lists AGPL v3).
Not in this PR (ledger nits): public/licenses/index.html lacks the EUPL-1.2 entry; unreferenced vendor/puzlwerk-capture-recovery-0.1.0 archive; Co-Authored-By trailers (Codex, Claude) missing from the contributor facts.
Review: CLEAR at this head (round 2, comment on this PR). CI run 44149040794 (test, typos) success.
Owner gates at merge: license change (copyright holder: owner), contributors (see findings), Pages publishes the AGPL-licensed app
Merge publishes: pages.yml deploys every push to main
Blocker: None.

🤖 Generated with Claude Code

wstein and others added 3 commits November 17, 2026 18:16
LICENSE is the verbatim text of https://www.gnu.org/licenses/agpl-3.0.txt
(sha256 0d96a4ff68ad6d4b6f1f30f713b18d5184912ba8dd389f86aa7710db079abcb0).
Owner decision 2026-11-17: #29 (comment)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ENTS

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@wstein

wstein commented Nov 17, 2026

Copy link
Copy Markdown
Owner Author

Review: FINDINGS head=2a9e34e38bc41363f053b22be6b1b53ed18ead58 patch-id=478f513645793a505f2e332298afc04d36b94df2 pr=63
blocking package-lock.json:10: root package still declares "license": "MIT"; package.json:55 says AGPL-3.0-or-later. Regenerate the lockfile root entry and assert it in test/projectLicense.test.ts.
nit test/projectLicense.test.ts:13-17: only lines 1-2 are checked; a LICENSE truncated after the header passes. Compare the SHA-256 (0d96a4ff...abcb0) instead.
nit test/projectLicense.test.ts:28: AGENTS.md check is negative only; "is GPL-2.0-only" passes. Assert the AGPL-3.0-or-later sentence.
nit public/licenses/index.html:15-22: EUPL-1.2 for @puzlwerk/capture-recovery (imported by src/client) is not listed; pre-existing on main, follow-up issue.
nit PR text: contributor facts omit Co-Authored-By trailers (Codex 221, Claude Sonnet 5.5 212, Claude Opus 5.5 9 over all refs).
nit vendor/puzlwerk-capture-recovery-0.1.0-f7a0082f.tgz: unreferenced EUPL-1.2 archive; pre-existing.
Verified: LICENSE is byte-identical to gnu.org agpl-3.0.txt (cmp 0, sha256 0d96a4ff...abcb0, 34523 bytes, LF, final newline).
Verified: AGENTS.md diff limited to lines 101-106; date and link match #29 comment 6956721339.
Verified: docs/orientation-recovery.md:118-120 and vendor/README.md:9-11 describe the archive's MIT notices; no contradiction.
Verified: vendored 0.3.0 package.json license EUPL-1.2, NOTICE, CUBE_ASSEMBLER_LICENSE.txt (MIT); EUPL Appendix line 177 lists AGPL v3.
Tests: new suite 3/3 fail on main files, 3/3 pass at head; 9 of 15 mutations fail at the intended assertion.
Checks: typecheck, lint, format:check, typos exit 0; npm test 1385 passed, 47 failed (LFS JPEG pointers, SOI not found).
Commits: 3 Conventional Commits, trailer present, author and committer match git config, diff --check clean, no session links.
CI: run 44146441750 (pull_request) success.

wstein and others added 2 commits November 17, 2026 18:31
…-or-later

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…TS.md sentence

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@wstein

wstein commented Nov 17, 2026

Copy link
Copy Markdown
Owner Author

Review: CLEAR head=96e32f71f14e6c2693f620c7806a32609a6f2dc9 patch-id=b0331d03f71b9db961cf5dac867afc01888dea39 pr=63
Delta 2a9e34e..96e32f7: 2 commits, package-lock.json 1 line (root license), test/projectLicense.test.ts.
Resolved: package-lock.json:10 root license is AGPL-3.0-or-later; npm ci --ignore-scripts and npm ls exit 0.
Lockfile: npm install --package-lock-only (npm 11.19.1, Linux) produces no diff against the edited lockfile.
Resolved: LICENSE test compares SHA-256 after CRLF to LF; AGENTS.md test asserts the AGPL sentence.
Tests: new suite at head 4/4 pass; with the 2a9e34e lockfile 1/4 fails (lockfile root).
Mutations: 13 of 16 fail at the intended assertion (lockfile MIT, LICENSE truncated/MIT/one byte/no final newline/BOM/CR only, AGENTS.md GPL-2.0-only/removed, README section/badge, CONTRIBUTING, package.json).
Survivors by design: LICENSE CRLF, lockfile CRLF.
nit test/projectLicense.test.ts:39-41: the negative AGENTS.md check was dropped; adding "CubeAssembler is MIT" next to the AGPL sentence passes.
Repo grep (MIT, "license") at head: no statement contradicts AGPL-3.0-or-later; only package.json at the root.
PR text: 18 lines, required lines present, "Not in this PR" lists the three remaining nits, no session links.
Checks: typecheck, lint, format:check, typos 1.52.2 exit 0; npm test 1386 passed, 47 failed (LFS JPEG pointers, SOI not found only).
Commits: 5 Conventional Commits, trailer present, author and committer match git config, diff --check clean.
CI: run 44149040794 (pull_request) success.

@wstein
wstein marked this pull request as ready for review November 17, 2026 18:50
@wstein
wstein merged commit 163ea26 into main Nov 17, 2026
2 checks passed
@wstein
wstein deleted the chore/relicense-agpl branch November 17, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant