Fix "Page not found" flash when clicking connectors - #594
Fix "Page not found" flash when clicking connectors#594Sachindu-Nethmin wants to merge 2 commits into
Conversation
|
Warning Review limit reached
Next review available in: 56 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughConnector cards now use Docusaurus client-side navigation, with trailing slashes removed from constructed connector paths. ChangesConnector navigation
Estimated code review effort: 2 (Simple) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@en/src/components/ConnectorCatalog/index.tsx`:
- Line 117: Update the Link construction in the connector catalog to use a valid
trailing-slash regex in the c.link.replace call, removing exactly one trailing
slash while preserving the existing catalogBase, key, and styling behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6831449a-9b6f-4612-abb8-964942ff4bda
📒 Files selected for processing (1)
en/src/components/ConnectorCatalog/index.tsx
Broken links, images & orphan pages
Links/images come from one crawl of the production build (baseUrl-aware). Orphans are docs not referenced by Summary
Broken links & imagesIntroduced by this PRNo new broken link(s)/image(s) introduced by this PR. ✅ Already on
|
1 participant
Purpose
Resolves #509
Fixes the issue where an abnormal "Page not found" page flashes before loading the correct content when a connector is clicked from the Connector Catalog.
Goals
Eliminate the 404 flash and provide a smooth SPA transition when navigating to connector pages.
Approach
The issue occurred because the
ConnectorCatalogcomponent used a standard HTML<a>tag with an explicitly appended trailing slash for connector links, while Docusaurus is configured withtrailingSlash: false. This mismatch caused the Docusaurus router to initially fail to match the route (resulting in a 404) before automatically normalizing the URL and redirecting to the correct page.This was fixed by:
@docusaurus/Linkcomponent instead of standard<a>tags to enable seamless client-side routing.trailingSlash: falseconfiguration.User stories
N/A
Release note
Fix "Page not found" flash when navigating to connectors in the catalog.
Documentation
N/A
Training
N/A
Certification
N/A
Marketing
N/A
Automation tests
N/A
N/A
Security checks
Samples
N/A
Related PRs
N/A
Migrations (if applicable)
N/A
Test environment
Tested locally on macOS using Chrome.
Learning
N/A
Summary by CodeRabbit