Skip to content

Fix unterminated string literal in resolution_label_notifier workflow - #5168

Open
Skynettheone wants to merge 1 commit into
wso2:mainfrom
Skynettheone:fix/resolution-label-notifier-syntax-error
Open

Skynettheone wants to merge 1 commit into
wso2:mainfrom
Skynettheone:fix/resolution-label-notifier-syntax-error

Conversation

@Skynettheone

@Skynettheone Skynettheone commented Aug 3, 2026

Copy link
Copy Markdown

Summary

The if: condition in .github/workflows/resolution_label_notifier.yml has an unterminated string literal:

contains(github.event.issue.labels.*.name, 'Resolution/Done)

The closing quote after Resolution/Done is missing, making the expression invalid.

Impact

Every run of this workflow since at least 2025-07-30 has ended in startup_failure:

$ gh run list --repo wso2/api-manager --workflow=resolution_label_notifier.yml --limit 10
...
startup_failure   2025-07-30T09:27:31Z   issues
startup_failure   2025-07-30T07:34:29Z   issues
startup_failure   2025-07-30T07:32:26Z   issues
...

GitHub's own diagnostic for these runs is "This run likely failed because of a workflow file issue." As a result, the workflow has never been able to comment on or reopen an issue that was closed without a proper Resolution/* label, silently defeating its entire purpose.

Change

Added the missing closing quote: 'Resolution/Done'.

Test plan

  • Parsed the fixed file with PyYAML (yaml.safe_load) to confirm it's valid YAML.
  • Verified the quote count in the if: expression is now balanced (was odd before the fix, even after).
  • Maintainer to confirm the next workflow run (on the next issue closed without a Resolution/ label) completes successfully rather than failing at startup.

The 'Resolution/Done condition was missing its closing quote,
making the if: expression invalid. Every run of this workflow since
at least 2025-07-30 has ended in startup_failure as a result, so it
has never actually been able to comment on or reopen an issue closed
without a proper Resolution/ label.

Add the missing closing quote.
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Skynettheone, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d86cddec-20ec-4056-ba6d-a07d97a9d59f

📥 Commits

Reviewing files that changed from the base of the PR and between c16a70e and d2a721e.

📒 Files selected for processing (1)
  • .github/workflows/resolution_label_notifier.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant