Repository navigation
Add poison pill for simulateJava task - #864
Conversation
This way gradle doesn't try to run simulateExternalJava
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f36df2802
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }); | ||
|
|
||
| project.getTasks().register("simulateJava", t -> { | ||
| throw new GradleException("The simulateJava task has been removed. Use run instead."); |
There was a problem hiding this comment.
Defer the poison-pill failure until task execution
When GradleRIO is applied to a Java project, gradle tasks realizes registered tasks while building its report, so this configuration action throws even though simulateJava was never requested. This makes routine task discovery fail, including the existing Java Project Initializes Correctly functional test and IDE task synchronization; place the exception in a doFirst or doLast action so it runs only when the poison-pill task is actually executed.
Useful? React with 👍 / 👎.
This way gradle doesn't try to run simulateExternalJava.
Closes #863