Skip to content

Add poison pill for simulateJava task - #864

Merged
PeterJohnson merged 2 commits into
wpilibsuite:mainfrom
ThadHouse:poisonpill
Sep 8, 2026
Merged

PeterJohnson merged 2 commits into
wpilibsuite:mainfrom
ThadHouse:poisonpill

Conversation

@ThadHouse

@ThadHouse ThadHouse commented Sep 3, 2026 •

Copy link
Copy Markdown
Member

This way gradle doesn't try to run simulateExternalJava.

Closes #863

This way gradle doesn't try to run simulateExternalJava
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-03T18:49:58.578502Z 1f36df2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1f36df2802

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

});

project.getTasks().register("simulateJava", t -> {
throw new GradleException("The simulateJava task has been removed. Use run instead.");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Defer the poison-pill failure until task execution

When GradleRIO is applied to a Java project, gradle tasks realizes registered tasks while building its report, so this configuration action throws even though simulateJava was never requested. This makes routine task discovery fail, including the existing Java Project Initializes Correctly functional test and IDE task synchronization; place the exception in a doFirst or doLast action so it runs only when the poison-pill task is actually executed.

Useful? React with 👍 / 👎.

@PeterJohnson
PeterJohnson merged commit a8028e1 into wpilibsuite:main Sep 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add poison pill for SimulateJava task

3 participants