Skip to content

Escape URL parameter in update-db and check-update-db network commands #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 1 commit into from
Aug 3, 2026
Merged

Escape URL parameter in update-db and check-update-db network commands #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions features/core-check-update-db.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,3 +98,12 @@ Feature: Check if WordPress database update is needed
Error: This is not a multisite installation.
"""
And the return code should be 1

Scenario: Check database update on network installation safely handles site domain/path with special characters
Given a WP multisite install
And I run `wp db query "INSERT INTO wp_blogs (site_id, domain, path, registered, last_updated) VALUES (1, 'example.com', '/x\\\$(touch /tmp/wpcli_test_check_db_marker)/', NOW(), NOW());"`

Comment on lines +104 to +105
When I run `wp core check-update-db --network`
Then the return code should be 0
And the /tmp/wpcli_test_check_db_marker file should not exist

4 changes: 2 additions & 2 deletions src/Core_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1510,7 +1510,7 @@ public function check_update_db( $args, $assoc_args ) {
foreach ( $it as $blog ) {
++$total;
$url = $blog->domain . $blog->path;
$cmd = "--url={$url} core check-update-db";
$cmd = Utils\esc_cmd( '--url=%s core check-update-db', $url );

/**
* @var object{stdout: string, stderr: string, return_code: int} $process
Expand Down Expand Up @@ -1628,7 +1628,7 @@ public function update_db( $args, $assoc_args ) {
foreach ( $it as $blog ) {
++$total;
$url = $blog->domain . $blog->path;
$cmd = "--url={$url} core update-db";
$cmd = Utils\esc_cmd( '--url=%s core update-db', $url );
if ( $dry_run ) {
$cmd .= ' --dry-run';
}
Expand Down
Loading