Touch popups: long-press reaches the amber function (Fn + MAIN RX/SUB RX/TX) - #9
Open
tcpreplay-dev wants to merge 2 commits into
Open
tcpreplay-dev wants to merge 2 commits into
tcpreplay-dev wants to merge 2 commits into
Conversation
FnMenuButton only armed the long-press timer in the compact phone layout; the regular tablet/iPad layout emitted the primary function immediately on press, so Fn -> long-press an amber action (e.g. DXLIST -> Log) fired the primary instead. Arm the long-press on any touch platform (Android/iOS) regardless of layout; desktop keeps click-to-primary plus right-click for the amber action. Scoped to the Fn popup (FnMenuButton) only, so main radio controls are unaffected. Reported by @aa5sh on iPad. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
RxMenuButton (MAIN RX / SUB RX / TX popups) had the same isCompact gate as the Fn popup: on the regular tablet/iPad layout it emitted the primary on press, so a long press could not reach the amber lower function (e.g. RX -> EQ). Arm the long-press on any touch platform (Android/iOS) for both press and release; desktop keeps click-to-primary plus right-click for the amber action. DISPLAY (DisplayPopupWidget) and the main radio controls (DualControlButton) use different interactions and are intentionally left unchanged. Verified on a Samsung tablet: MAIN RX -> long-press RX opens the RX Graphic Equalizer (amber EQ). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
tcpreplay-dev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes long-press on the touch popups so it reaches the amber (lower) function on the tablet/iPad layout.
Bug
FnMenuButton(Fn popup) andRxMenuButton(MAIN RX / SUB RX / TX popups) only armed their long-press timer in the compact phone layout. On the regular tablet/iPad layout they emitted the primary function immediately on press, so a long press could not reach the amber lower function (e.g.DXLIST→Log,RX→EQ). Touch has no right-click, so there was no way to reach the amber function at all on iPad/tablet. Reported by @aa5sh on iPad.Fix
Arm the long-press on any touch platform (Android/iOS), regardless of compact vs regular layout, for both the Fn popup and the MAIN RX / SUB RX / TX popups. Short tap still fires the primary; a ~550 ms hold fires the amber (
rightClicked) action, which was already wired unconditionally. Desktop is unchanged (click = primary, right-click = amber).Scoped to the popup button classes only. DISPLAY (
DisplayPopupWidget) and the main radio controls (DualControlButton) use different interactions and are intentionally left unchanged.Testing
Verified on a Samsung Android tablet:
Fn→ long-pressDXLISTopens the Logbook (amberLog); short tap opensDXLIST.MAIN RX→ long-pressRXopens the RX Graphic Equalizer (amberEQ).Same code path on iPad.
🤖 Generated with Claude Code