iOS: FREQ ENT numeric keypad when no keyboard, respecting B SET - #8
Draft
tcpreplay-dev wants to merge 2 commits into
Draft
tcpreplay-dev wants to merge 2 commits into
tcpreplay-dev wants to merge 2 commits into
Conversation
FREQ ENT on the right panel toggled the inline blue edit field, which needs a hardware keyboard to type into — leaving touch users with no keyboard stuck. Now: - No hardware keyboard: open the on-screen numeric keypad dialog (the same one the compact layout's A FREQ button uses). - Hardware USB/Bluetooth keyboard attached: keep the inline edit field. - Both paths honor B SET (act on VFO B when the Sub RX is targeted). Android detects a usable hardware keyboard via Configuration.keyboard / hardKeyboardHidden (flips live on attach/remove). iOS is treated as touch-only here; hardware-keyboard detection for iPad (GCKeyboard) lands on the iOS branch. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
… attached Adds GCKeyboard-based hardware-keyboard detection so the FREQ ENT change behaves correctly on iOS/iPad: - src/ios/ioskeyboard.mm/.h: iosHasHardwareKeyboard() backed by GameController. A bare GCKeyboard.coalescedKeyboard read stays stale after a Bluetooth keyboard is switched off, so iosStartKeyboardMonitoring() (called from main) registers GCKeyboardDidConnect/Disconnect observers and caches live state. - CMakeLists: build ioskeyboard.mm (ARC) and link -framework GameController. - FREQ ENT: no keyboard -> on-screen numeric keypad; hardware USB/BT keyboard -> inline blue edit field. Both honor B SET. Verified on an iPad Pro 13" (M5): keyboard off shows the keypad, keyboard on uses the inline field, and B SET targets VFO B. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
tcpreplay-dev
marked this pull request as draft
September 13, 2026 23:27
tcpreplay-dev
marked this pull request as ready for review
September 13, 2026 23:32
tcpreplay-dev
marked this pull request as draft
September 13, 2026 23:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves FREQ ENT on iOS/iPad so it works without a hardware keyboard, and uses the inline edit field when one is attached — targeted at
codex/ios.FREQ ENT: keypad when no keyboard, and respect B SET
The right-panel FREQ ENT opened the inline blue edit field, which needs a keyboard to type into. Now:
iOS hardware-keyboard detection
src/ios/ioskeyboard.mm/.h—iosHasHardwareKeyboard()backed by GameController'sGCKeyboard. A bareGCKeyboard.coalescedKeyboardread stays stale after a Bluetooth keyboard is switched off, soiosStartKeyboardMonitoring()(called frommain) registersGCKeyboardDidConnect/Disconnectobservers and caches live state.CMakeLists.txt— buildsioskeyboard.mmwith ARC and links-framework GameController.The shared handler change (first commit) is the same one going to
codex/android-tablet; this branch adds the iOS-specific detection on top.Testing
Verified on an iPad Pro 13" (M5): keyboard off shows the keypad, keyboard on uses the inline field, and B SET targets VFO B.
🤖 Generated with Claude Code