iOS: App Store / TestFlight distribution readiness - #12
Open
tcpreplay-dev wants to merge 2 commits into
Open
tcpreplay-dev wants to merge 2 commits into
tcpreplay-dev wants to merge 2 commits into
Conversation
Make the iOS bundle identifier a cache variable (QK4_IOS_BUNDLE_ID) defaulting to the existing com.w9wdx.qk4phone, so forks and TestFlight builds signed by a different Apple team can override it with -DQK4_IOS_BUNDLE_ID=... instead of editing CMakeLists. No change to the default identity. Also force DEBUG_INFORMATION_FORMAT=dwarf-with-dsym: the CMake Xcode generator otherwise ships archives without a dSYM, producing the App Store Connect "Upload Symbols Failed" warning and unsymbolicated crashes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
NSCameraUsageDescription: static Qt Multimedia links camera API symbols even though QK4 only uses QAudioSink/QAudioSource, so App Store processing rejects the binary (ITMS-90683) without a camera purpose string. Add one stating the app does not use the camera. ITSAppUsesNonExemptEncryption=false: QK4's only cryptography is standard TLS-PSK via OpenSSL, which qualifies for the export-compliance exemption. Declaring it in the plist clears the "Missing Compliance" prompt on every TestFlight/App Store upload. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes discovered while getting an iOS build onto TestFlight. All four are prerequisites for uploading to App Store Connect; none change the default app identity or runtime behavior.
Changes
Configurable bundle id (
QK4_IOS_BUNDLE_IDcache var, defaults tocom.w9wdx.qk4phone)Lets a fork or a TestFlight build signed by a different Apple team override the identifier with
-DQK4_IOS_BUNDLE_ID=your.idinstead of editing CMakeLists. Default identity is unchanged — a normal build is byte-for-byte the same.dSYM emission (
DEBUG_INFORMATION_FORMAT=dwarf-with-dsym)The CMake Xcode generator otherwise archives without a dSYM, producing the App Store Connect "Upload Symbols Failed" warning and unsymbolicated crash reports.
NSCameraUsageDescriptionStatic Qt Multimedia links camera API symbols even though QK4 only uses
QAudioSink/QAudioSource. App Store processing rejects the binary (ITMS-90683) without a camera purpose string. Added one stating the app does not use the camera.ITSAppUsesNonExemptEncryption = falseQK4's only cryptography is standard TLS-PSK via OpenSSL, which qualifies for the export-compliance exemption. Declaring it in the plist clears the "Missing Compliance" prompt on every upload.
Verification
Configured clean for iOS Release with
-DQK4_IOS_BUNDLE_ID=dev.tcpreplay.qk4; a full archive + upload of this tree reached TestFlight (build processed, compliance cleared) under the tcpreplay-dev Apple team.🤖 Generated with Claude Code