Make buffer capabilities composable#266
Merged
Merged
Conversation
…t method instead of from_slice across multiple files
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the buffer abstraction so backend capabilities are more composable and more protocol work can stay buffer-native.
from_vec/from_sliceconstructors with standardFrom<Vec<T>>andFrom<&[T]>implementations.BufferOpsandBufferMathare composable rather than hierarchical.BufferOpsinto a dedicatedMerklizetrait.ones,bilinear_form,tensor_product,mat_vec,concat,eq_weights, and geometric challenge generation.Bufferand addvalues_bufferto avoid unnecessary readbacks in prover paths.Notes For Reviewers
geometric_challenge_groupsis intended to match drawing one host geometric challenge and slicing it into contiguous groups, but without reading the sequence back from the backend.