add mobench support to ProveKit v1#451
Merged
Merged
Conversation
Collaborator
Author
Latest mobile benchmark numbersReposted from #430 comment #430 (comment). Source: Mobile Bench PR Auto run 26368378198 on iOS
Android
Memory growth is the benchmark-reported peak growth above baseline; process peak is the reported process RSS peak. |
…-fix # Conflicts: # .github/workflows/ci.yml
Mobench Benchmark ResultsIos Benchmark ResultsBenchmark Summary
Note: memory growth excludes warmup/baseline retained before the measured iteration. Android Benchmark ResultsBenchmark Summary
Note: memory growth excludes warmup/baseline retained before the measured iteration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
@Bisht13 ready for review once the fresh rerun settles. I pushed |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopened from #430 using the new
dcbuilder/*branch naming.Old PR: #430
Replacement branch:
dcbuilder/pr430-mobench-v1-browserstackOld head branch:
dcbuild3r/mobench-v1-browserstackHead SHA:
94786155017ac2b11505a012ddb181f9e8a1a1c6Previous PR CI / benchmark runs from #430:
Summary
provespanAndroid mobench fix note
The earlier failing run was https://github.com/worldfnd/provekit/actions/runs/26002840796. The missing Vivo Y21 monolithic cell did not recover a BrowserStack session payload or
summary.json; available artifacts only show the BrowserStack fetch timeout after 7200s for buildb1ebace919a1b8cad3861313180ac9a18a7e461d.Before/failure memory from that run:
What changed:
profile_phase("prove")wraps only the prover entry point. Previouslyprepared.clone()ran insideprofile_phase("prove"), so clone cost and peak memory were charged to proving.failure.jsonnow records attempts, fetch timeout seconds, build id, and any LMK/OOM/SIGKILL lines recovered from attempt/device logs.Latest benchmark numbers were reposted as a PR comment from #430.
Validation
cargo fmt --allcargo test -p bench-mobile --libcargo test -p bench-mobile --test examples_smokecargo test -p bench-mobile --test passport_smokecargo check -p provekit-ffi --target aarch64-linux-androidwith NDK 26.1aarch64-linux-android34-clangruby -e 'require "yaml"; YAML.load_file(".github/workflows/mobile-bench-reusable.yml")'git diff --check