Expand interpreter coverage: references, match, intrinsics, aggregate format#2
Open
BornPsych wants to merge 7 commits into
Open
Expand interpreter coverage: references, match, intrinsics, aggregate format#2BornPsych wants to merge 7 commits into
BornPsych wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of the
import-interpreter-cratePR. This teaches the interpreter the constructs it previously rejected asUnsupported, so they stop being silently excluded from the cross-field differential. Every addition is field-independent and verified against Noir's ACVM executor: 69 bn254 tests, 51 goldilocks tests, clippy and fmt clean, and the ~505-programexecution_successcorpus survey at 0 MISMATCH / 0 FALSE-REJECTION (395 agree, up from 383).The six commits are sequenced so the feature set reads as a progression:
Valuefoundation (cell-backed tuples plus aRefvalue) that all aliasing builds on.&mutparameters,&mut s.field, and nested/multi-level references, including the&mut a.b.c-through-a-reference case.matcharm over the(tag, payload…)enum layout, with integer, boolean, and field scrutinees.black_box,as_witness,assert_constant) and the range-check and bit-spread builtins.==/!=on arrays, tuples, and structs, and assertionf"…"message rendering.