chore: align Rust toolchains on 1.98.1 - #509
Draft
Dzejkop wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin WalletKit's development, CI, crate release, and Swift release compilers to Rust 1.98.1 for the shared Rust rollout. Refresh only the Nix Rust overlay so the host, WASM, and Android shells resolve this release. Preserve the declared Rust 1.91 workspace MSRV.
Retain the compatibility fixes from the original 1.97.1 upgrade and use fixed-size chunks when decoding cached issuer schema IDs to satisfy Rust 1.98 Clippy without changing the byte format. Cargo dependencies and
Cargo.lockare unchanged.Validation
cargo +1.98.1 fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningsgit diff --check504responses while fetching pinned World ID circuit artifacts; leave the test suite, cross-target builds, foreign bindings, and nightly docs to CI.Cargo reports the existing future-incompatibility warning in
proc-macro-error22.0.1.Rollout dependency
Keep this PR in draft until Infrastructure #48339, Bedrock #437, Oxide #1190, Biometric Engines #648, and Flamingo #104 are ready. Version alignment will intentionally fail while the organization variable remains 1.94.1. No live variable or infrastructure change is made here.
AI usage/prompt(s)
Codex: “Adjust the coordinated Rust upgrade PRs to align on Rust 1.98.1, validate compatibility, and include Flamingo now that it participates in organization version alignment.”