feat: add fanout failure and target health metrics and v0.1.2 - #56
Open
Kemperino wants to merge 8 commits into
Open
feat: add fanout failure and target health metrics and v0.1.2#56Kemperino wants to merge 8 commits into
Kemperino wants to merge 8 commits into
Conversation
Kemperino
requested review from
0xForerunner,
0xOsiris,
Dzejkop,
alessandromazza98,
cichaczem,
karankurbur,
kilianglas and
piohei
as code owners
August 20, 2026 12:16
Dzejkop
reviewed
Aug 20, 2026
Dzejkop
reviewed
Aug 20, 2026
Dzejkop
reviewed
Aug 20, 2026
Comment on lines
+27
to
+34
| describe_counter!( | ||
| "fanout_total_failures", | ||
| "Fanout requests where every target failed" | ||
| ); | ||
| describe_gauge!( | ||
| "fanout_target_healthy", | ||
| "Whether the latest request to a fanout target succeeded" | ||
| ); |
Contributor
There was a problem hiding this comment.
this is inconsistent with the current setup
I think we should move these as fields into the ProxyMetrics struct
Contributor
There was a problem hiding this comment.
also this made me notice that:
-
We're not calling
ProxyMetrics::describeanywhere - and we should
As per the Metrics macro docs:
creates a [Default](https://doc.rust-lang.org/stable/core/default/trait.Default.html) implementation for the struct registering all of
the metrics.
so we should just remove ProxyMetrics::new entirely and just call ::default()
Dzejkop
reviewed
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Cursor Bugbot is generating a summary for commit 40c8c03. Configure here.