chore(iris-mpc-store): Try fetching missing serial ids as last resort - #2385
Open
wojciechsromek wants to merge 3 commits into
Open
chore(iris-mpc-store): Try fetching missing serial ids as last resort#2385wojciechsromek wants to merge 3 commits into
wojciechsromek wants to merge 3 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
eaypek-tfh
approved these changes
Sep 4, 2026
philsippl
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new method to stream iris records by explicit serial IDs and integrates it into the database loader for improved recovery of missing records. It also adds comprehensive tests for the new streaming method and enhances error handling and logging when recovering missing data.
New streaming method for irises by ID:
Store::stream_irises_by_ids, allowing efficient streaming of iris records by a list of explicit serial IDs, with missing IDs simply skipped rather than causing an error.Database loader improvements:
load_iris_db_internal), enabling a final recovery step that fetches missing records by their IDs, with chunking and a configurable cap to avoid large queries. [1] [2] [3] [4]Testing and validation:
test_stream_irises_by_ids) to verify correct results, handling of missing IDs, and empty input for the new streaming method.Code organization: