Skip to content

chore(iris-mpc-store): Try fetching missing serial ids as last resort - #2385

Open
wojciechsromek wants to merge 3 commits into
mainfrom
chore/if-missing-serial-ids-inside-set-also-feetch
Open

chore(iris-mpc-store): Try fetching missing serial ids as last resort#2385
wojciechsromek wants to merge 3 commits into
mainfrom
chore/if-missing-serial-ids-inside-set-also-feetch

Conversation

@wojciechsromek

@wojciechsromek wojciechsromek commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

This pull request introduces a new method to stream iris records by explicit serial IDs and integrates it into the database loader for improved recovery of missing records. It also adds comprehensive tests for the new streaming method and enhances error handling and logging when recovering missing data.

New streaming method for irises by ID:

  • Added Store::stream_irises_by_ids, allowing efficient streaming of iris records by a list of explicit serial IDs, with missing IDs simply skipped rather than causing an error.

Database loader improvements:

  • Integrated the new streaming method into the loader (load_iris_db_internal), enabling a final recovery step that fetches missing records by their IDs, with chunking and a configurable cap to avoid large queries. [1] [2] [3] [4]

Testing and validation:

  • Added a dedicated test (test_stream_irises_by_ids) to verify correct results, handling of missing IDs, and empty input for the new streaming method.

Code organization:

  • Improved imports and chunking logic in the loader to support the new streaming approach. [1] [2]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T12:39:01.901678Z d6e1a0b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants