feat: use @nobles/curves for 25519 sig verification#31
Merged
Conversation
paolodamico
requested review from
Takaros999,
andy-t-wang and
m1guelpf
as code owners
0xOsiris
approved these changes
May 13, 2026
Takaros999
approved these changes
May 20, 2026
Contributor
Takaros999
left a comment
Takaros999
left a comment
There was a problem hiding this comment.
can you add a changeset file as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While
tweetnaclis heavily used, it hasn't been updated in 6 years. For Solana (which uses 25519), we move to@nobles/curveswhich is already being pulled by viem. Tests generated by AI.